Skip to content

Render Document inputs#266

Merged
jaredjj3 merged 5 commits intomasterfrom
inputs
Feb 23, 2025
Merged

Render Document inputs#266
jaredjj3 merged 5 commits intomasterfrom
inputs

Conversation

@jaredjj3
Copy link
Collaborator

This PR fixes #265 by extending the parsing.MusicXMLParser and renderMusicXML signatures to accept XMLDocument objects.

@jaredjj3 jaredjj3 self-assigned this Feb 23, 2025
@jaredjj3 jaredjj3 marked this pull request as ready for review February 23, 2025 13:26
@jaredjj3
Copy link
Collaborator Author

jaredjj3 commented Feb 23, 2025

@yfyf, I used Document instead of XMLDocument because XMLDocument extends Document. Your use case should be covered. This PR will be included in ^0.1.3.

@jaredjj3 jaredjj3 changed the title Render XMLDocument inputs Render Document inputs Feb 23, 2025
@jaredjj3 jaredjj3 merged commit 46fbed2 into master Feb 23, 2025
1 check passed
@jaredjj3 jaredjj3 deleted the inputs branch February 23, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface for rendering a parsed XMLDocument?

1 participant